| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel |
| Date: | 2018-10-11 19:04:24 |
| Message-ID: | 20181011190424.gxgovoezirc5skgv@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-10-09 17:39:09 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2018-10-09 17:27:17 -0400, Tom Lane wrote:
> >> I complained about this already on the other thread, I think, but:
> >> I do not think we should remove timeofday(). It's unrelated to these
> >> datatypes and it offers functionality that isn't quite duplicated
> >> elsewhere.
>
> > Ok. I find it a somewhat weird function, but I agree it's not strongly
> > related. It only came up because it's implemented in nabstime.c. Moving
> > it to utils/adt/timestamp.c seems to make the most sense?
>
> Sure, if you want to flush nabstime.c completely, just shove it over
> there.
I've done that now, together with two commits for removal of timetravel
and abstime, reltime, tinterval.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-10-11 19:45:37 | Re: Soon-to-be-broken regression test case |
| Previous Message | Andres Freund | 2018-10-11 17:41:57 | Re: TupleTableSlot abstraction |