Re: pgsql: Make WAL segment size configurable at initdb time.

From: Andres Freund <andres(at)anarazel(dot)de>
To: David Steele <david(at)pgmasters(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make WAL segment size configurable at initdb time.
Date: 2018-10-05 16:54:47
Message-ID: 20181005165447.zyzglieznybyi7wu@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2018-09-20 11:48:08 -0400, David Steele wrote:
> Hi Andres,
>
> On 9/20/17 1:04 AM, Andres Freund wrote:
> >
> > Make WAL segment size configurable at initdb time.
>
> <...>
>
> > https://git.postgresql.org/pg/commitdiff/fc49e24fa69a15efacd5b8958115ed9c43c48f9a
> It appears that fc49e24f missed updating the runtime config presets
> documentation.
>
> Patch attached.
>
> Regards,
> --
> -David
> david(at)pgmasters(dot)net

> diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
> index e1073ac6d3..3bfd172441 100644
> --- a/doc/src/sgml/config.sgml
> +++ b/doc/src/sgml/config.sgml
> @@ -8440,10 +8440,8 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir'
> </term>
> <listitem>
> <para>
> - Reports the number of blocks (pages) in a WAL segment file.
> - The total size of a WAL segment file in bytes is equal to
> - <varname>wal_segment_size</varname> multiplied by <varname>wal_block_size</varname>;
> - by default this is 16MB. See <xref linkend="wal-configuration"/> for
> + Reports the size of write ahead log segments.
> + The default value is 16MB. See <xref linkend="wal-configuration"/> for
> more information.
> </para>
> </listitem>

Why is this actually more correct? You mean because we have a conversion
that does the mb conversion at display time?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Steele 2018-10-05 17:03:44 Re: pgsql: Make WAL segment size configurable at initdb time.
Previous Message Tom Lane 2018-10-05 16:45:51 pgsql: Ensure that PLPGSQL_DTYPE_ROW variables have valid refname field

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-10-05 16:58:19 Re: Performance improvements for src/port/snprintf.c
Previous Message David Steele 2018-10-05 16:41:56 Re: pgsql: Make WAL segment size configurable at initdb time.