Re: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when printing

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when printing
Date: 2018-10-03 20:30:11
Message-ID: 20181003203011.c2euts5hqhc6xpcw@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2018-10-03 16:24:23 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Ensure that snprintf.c's fmtint() doesn't overflow when printing INT64_MIN.
>
> Hm, I think you should s/uint64/unsigned long long/ to be consistent
> with 595a0eab7.

Fair point. Will push once tests finish.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-10-03 20:34:17 pgsql: Replace uint64 use introduced in 4868e446859 in light of 595a0ea
Previous Message Tom Lane 2018-10-03 20:24:23 Re: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when printing