Re: Performance improvements for src/port/snprintf.c

Hi,

On 2018-09-26 21:30:25 -0400, Tom Lane wrote:
> Here's a rebased version of <15785(dot)1536776055(at)sss(dot)pgh(dot)pa(dot)us>.
>
> I think we should try to get this reviewed and committed before
> we worry more about the float business. It would be silly to
> not be benchmarking any bigger changes against the low-hanging
> fruit here.

I've looked through the patch. Looks good to me. Some minor notes:

- How about adding our own strchrnul for the case where we don't
HAVE_STRCHRNUL? It's possible that other platforms have something
similar, and the code wouldlook more readable that way.
- I know it's not new, but is it actually correct to use va_arg(args, int64)
for ATYPE_LONGLONG?

Greetings,

Andres Freund