Re: automatic restore point

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: "Yotsunaga, Naoki" <yotsunaga(dot)naoki(at)jp(dot)fujitsu(dot)com>, 'Postgres hackers' <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: automatic restore point
Date: 2018-09-30 12:45:10
Message-ID: 20180930124510.GB1763@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 28, 2018 at 09:13:17PM +0200, Peter Eisentraut wrote:
> I think this should be done using event triggers. Right now, you just
> have it hardcoded to TRUNCATE and DROP TABLE, which seems somewhat
> arbitrary. With event triggers, you have the full flexibility to do
> what you want. You can pick which commands to apply it to, you can log
> the LSN, you can create restore points, etc.

I still unfortunately don't see what this patch brings more that you
cannot do. Event triggers are particularly useful in this prospective,
so I am marking the patch as rejected.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-09-30 12:47:54 Re: [Patch] Create a new session in postmaster by calling setsid()
Previous Message Michael Paquier 2018-09-30 12:40:31 Re: Use durable_unlink for .ready and .done files for WAL segment removal