| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [HACKERS] Something for the TODO list: deprecating abstime and friends |
| Date: | 2018-09-28 22:32:40 |
| Message-ID: | 20180928223240.kgwc4czzzekrpsid@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-12-13 00:05:06 -0800, Andres Freund wrote:
> > * contrib/spi/timetravel depends on abstime columns to represent what
> > would nowadays be better done as a tstzrange. I'd have thought we
> > could maybe toss that example module overboard, but we just today got
> > a question about its usage, so I'm afraid it's not quite dead yet.
> > What shall we do with that?
>
> Looking at the code I'd be pretty strongly inclined to scrap it.
>
>
> Before I'd discovered this thread, I'd started to write up a
> patch. Attached. It's clearly not fully done. Questions I'd while
> hacking things up:
> - what to do with contrib/spi/timetravel - I'd just removed it from the
> relevant Makefile for now.
> - nabstime.c currently implements timeofday() which imo is a pretty
> weird function. I'd be quite inclined to remove it at the same time as
> this.
Here's a refreshed version of this patch. First patch removes
contrib/spi/timetravel, second patch removes abstime, reltime, tinterval
together with timeofday().
I think we should just go ahead and commit something like this soon.
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-timetravel-extension.patch | text/x-diff | 25.4 KB |
| v1-0002-Remove-deprecated-abstime-reltime-tinterval-datat.patch | text/x-diff | 163.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-28 22:41:27 | Re: Odd 9.4, 9.3 buildfarm failure on s390x |
| Previous Message | Mark Wong | 2018-09-28 22:22:23 | Re: Odd 9.4, 9.3 buildfarm failure on s390x |