| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove absolete function TupleDescGetSlot(). |
| Date: | 2018-09-26 01:38:51 |
| Message-ID: | 20180926013851.GG1659@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote:
>> git grep TupleDescGetSlot
>> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated TupleDescGetSlot().
>> src/include/funcapi.h: * user-defined SRFs that use the deprecated TupleDescGetSlot().
>
> But here I'm less convinced. It's not entirely clear to me that the only
> real reason for this to exists actually was TupleDescGetSlot(). OTOH, I
> can't really see any proper reason to have it either.
I have not been following the recent thread about the refactoring of
TupleSlot and such very closely, but if you don't plan to use
TupleTableSlot in FuncCallContext in the future, cannot this just go
away? The function is not here anymore, so my take would be to get rid
of all things which relied on its presence.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-26 01:42:51 | Re: pgsql: Remove absolete function TupleDescGetSlot(). |
| Previous Message | Michael Paquier | 2018-09-26 01:33:13 | pgsql: Rework activation of commit timestamps during recovery |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-26 01:42:51 | Re: pgsql: Remove absolete function TupleDescGetSlot(). |
| Previous Message | Michael Paquier | 2018-09-26 01:34:01 | Re: when set track_commit_timestamp on, database system abort startup |