Re: Proposal for Signal Detection Refactoring

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Chris Travers <chris(dot)travers(at)adjust(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal for Signal Detection Refactoring
Date: 2018-09-25 01:13:11
Message-ID: 20180925011311.GD1354@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 24, 2018 at 09:03:49PM -0400, Tom Lane wrote:
> You could only fix that by blocking all signal handling during the
> handler, which would be expensive and rather pointless.
>
> I do not think that it's readily possible to improve on the current
> situation with one sig_atomic_t per flag.

Okay, thanks for the confirmation.

At the same time, all the pending flags in miscadmin.h could be switched
to sig_atomic_t if we were to be correct, no? The counters could be
higher than 256 so that's not really possible.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-09-25 01:38:11 Re: Proposal for Signal Detection Refactoring
Previous Message Tom Lane 2018-09-25 01:03:49 Re: Proposal for Signal Detection Refactoring