| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> | 
|---|---|
| To: | nagata(at)sraoss(dot)co(dot)jp | 
| Cc: | pgsql-hackers(at)postgresql(dot)org | 
| Subject: | Re: Unused argument from execute_sql_string() | 
| Date: | 2018-09-13 06:47:26 | 
| Message-ID: | 20180913.154726.1208318118567527730.t-ishii@sraoss.co.jp | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
> Hi,
> 
> I found that a argument "filename" is not used in execute_sql_string() 
> although the comment says "filename is used only to report errors.",
> so I think we can remove this argument as done in the patch I attached.
It seems the "filename" argument has been there since the first
version of extension.c was committed. I don't know why it has been
left unused. Maybe someone thought someday he generates more fancy
error reports using it?
Anyway, considering it's a static function, chance of breaking
backward compatibility is minimum, I think.
So +1 to remove the unused argument.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-09-13 07:03:40 | Re: Collation versioning | 
| Previous Message | Kyotaro HORIGUCHI | 2018-09-13 06:29:27 | Re: A strange GiST error message or fillfactor of GiST build |