From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Andrew Gierth <rhodiumtoad(at)postgresql(dot)org> |
Cc: | Postgres commits <pgsql-committers(at)postgresql(dot)org>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
Date: | 2018-09-06 05:16:08 |
Message-ID: | 20180906051608.GI2726@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi Andrew,
On Wed, Sep 05, 2018 at 09:45:49PM +0000, Andrew Gierth wrote:
> Allow extensions to install built as well as unbuilt headers.
>
> Commit df163230b overlooked the case that an out-of-tree extension
> might need to build its header files (e.g. via ./configure). If it is
> also doing a VPATH build, the HEADERS_* rules in the original commit
> would then fail to find the files, since they would be looking only
> under $(srcdir) and not in the build directory.
>
> Fix by adding HEADERS_built and HEADERS_built_$(MODULE) which behave
> like DATA_built in that they look in the build dir rather than the
> source dir (and also make the files dependencies of the "all" target).
>
> No Windows support appears to be needed for this, since it is only
> relevant to out-of-tree builds (no support exists in Mkvcbuild.pm to
> build extension header files in any case).
prairiedog is unhappy with this commit:
make -C ../../../contrib/spi
../../src/makefiles/pgxs.mk:140: Extraneous text after `else' directive
../../src/makefiles/pgxs.mk:144: *** only one `else' per conditional.
Stop.
make[2]: *** [submake-contrib-spi] Error 2
make[2]: *** Waiting for unfinished jobs....
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2018-09-05%2023%3A21%3A01
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2018-09-06 05:26:51 | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
Previous Message | Amit Kapila | 2018-09-06 05:01:50 | pgsql: Fix the overrun in hash index metapage for smaller block sizes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2018-09-06 05:26:51 | Re: pgsql: Allow extensions to install built as well as unbuilt headers. |
Previous Message | Richard Guo | 2018-09-06 04:01:34 | Re: Implement predicate propagation for non-equivalence clauses |