| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| Date: | 2018-09-04 17:29:57 |
| Message-ID: | 20180904172957.GC20696@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 04, 2018 at 02:52:07PM +0000, Tom Lane wrote:
> Clean up after TAP tests in oid2name and vacuumlo.
>
> Oversights in commits 1aaf532de and bfea331a5. Unlike the case for
> traditional-style REGRESS tests, pgxs.mk doesn't have any builtin support
> for TAP tests, so it doesn't realize it should remove tmp_check/.
> Maybe we should build some actual pgxs infrastructure for TAP tests ...
> but for the moment, just remove explicitly.
Thanks for fixing this. I think that there is an argument for just
moving the cleanup of $(pg_regress_clean_files) in pgxs.mk out of the
REGRESS portion instead? I see little need for new infrastructure
here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-04 17:41:53 | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| Previous Message | Tom Lane | 2018-09-04 14:52:07 | pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-04 17:41:53 | Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo. |
| Previous Message | Thomas Munro | 2018-09-04 17:04:42 | Re: Collation versioning |