| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Kukushkin <cyberdemn(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15346: Replica fails to start after the crash |
| Date: | 2018-08-30 13:39:11 |
| Message-ID: | 20180830133911.GA15446@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Aug 30, 2018 at 10:55:23AM +0200, Alexander Kukushkin wrote:
> Bgwriter itself never changes updateMinRecoveryPoint to true and boom,
> we can get a lot of pages written to disk, but minRecoveryPoint in the
> pg_control won't be updated!
That's indeed obvious by reading the code. The bgwriter would be
started only once a consistent point has been reached, so the startup
process would have normally already updated the control file to the
consistent point. Something like the attached should take care of the
problem. As the updates of the local copy of minRecoveryPoint strongly
rely on if the startup process is used, I think that we should use
InRecovery for the sanity checks.
I'd like to also add a TAP test for that, which should be easy enough if
we do sanity checks by looking up at the output of the control file.
I'll try to put more thoughts on that.
Does it take care of the problem?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| min-consistent-update-v1.patch | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kukushkin | 2018-08-30 14:03:43 | Re: BUG #15346: Replica fails to start after the crash |
| Previous Message | Alexander Kukushkin | 2018-08-30 08:55:23 | Re: BUG #15346: Replica fails to start after the crash |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2018-08-30 13:48:26 | Re: pg_upgrade fails saying function unaccent(text) doesn't exist |
| Previous Message | Etsuro Fujita | 2018-08-30 12:58:04 | Re: Problem while updating a foreign table pointing to a partitioned table on foreign server |