Re: Removing useless \. at the end of copy in pgbench

On 2018-08-29 21:42:42 +0200, Fabien COELHO wrote:
>
> Hello,
>
> > What about:
> >
> > """
> > Pgbench requires a PostgreSQL version 8.2 or above server.
> > """
> >
> > Some information is provided...
> >
> > I understood that Tom found that an explicit compatibility note would be
> > welcome, so I provided one. I'm also fine with saying nothing.
>
> Here is a patch with the following accurate information:
>
> """
> In order to run, pgbench requires a PostgreSQL server version 8.2 or above.
> """
>
> 8.2 has been tested by Tom, and is required because of DROP TABLE IF EXISTS
> & CREATE TABLE ... FILLFACTOR, which I pointed out in a mail upthread.
>
> Now if the information is not added to the doc, this is also fine with me.

I'd vote for not adding it. It seems almost guaranteed to get out of
date without anybody noticing so. Maybe that's overly pragmatic, but I
really can't see the harm of not documenting which precise ancient
version pgbench doesn't support anymore...

Greetings,

Andres Freund