From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: typcache.c typos |
Date: | 2018-08-28 13:21:27 |
Message-ID: | 20180828132127.GI29157@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 28, 2018 at 01:57:12PM +0900, Amit Langote wrote:
> On 2018/08/28 13:42, David Rowley wrote:
>> On 28 August 2018 at 16:40, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>>> I've attached a patch to fix a typo in typcache.c. I ended up also
>>> rephrasing the sentence since "information about data types that is",
>>> almost made me also want to change "is" to "are", since "types" is
>>> plural. That would have been a mistake since it's talking about the
>>> information and not the types.
Your new phrasing looks correct to me, as information about the type is
what is referenced, and not the data type itself.
> - * The type cache exists to speed lookup of certain information about data
>
> [ ... ]
>
> + * The type cache exists to speedup lookups of certain data type information
>
> Sorry if I'm being ignorant, but shouldn't it be "to speed up or to
> speed-up" instead of "to speedup?
I know "speed up" as a correct verb, and speedup can be used as a noun.
I don't know about "speed-up" though.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2018-08-28 13:29:40 | Re: Stored procedures and out parameters |
Previous Message | Michael Paquier | 2018-08-28 13:13:54 | Re: pg_verify_checksums failure with hash indexes |