Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
Date: 2018-08-24 15:46:23
Message-ID: 20180824154623.i32aryx4bzfa4gxu@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

Hi,

On 2018-08-23 18:44:34 -0700, Andres Freund wrote:
> Pushed the first two.

Seems to have worked like expected.

> I'll send the presumably affected buildfarm owners an email, asking
> them whether they want to update.

Did that.

Andrew, as expected my buildfarm animal mylodon, which uses compiler
flags to enforce C89 compliance, failed due to this commit:
https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=mylodon&br=HEAD

I'd like to change it so it doesn't enforce C89 compliance across the
board, but instead enforces the relevant standard. For that I'd need to
change CFLAGS per-branch in the buildfarm. Is that possible already? Do
I need two different config files?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-24 15:47:43 Re: remove ATTRIBUTE_FIXED_PART_SIZE
Previous Message Andres Freund 2018-08-24 15:42:37 master, static inline and #ifndef FRONTEND

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2018-08-24 16:10:34 Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
Previous Message Jonathan S. Katz 2018-08-24 13:00:04 Re: Mailing list link on website points to subscription page