Re: NLS handling fixes.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: NLS handling fixes.
Date: 2018-08-21 06:22:50
Message-ID: 20180821062250.GH2897@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 21, 2018 at 11:49:05AM +0900, Kyotaro HORIGUCHI wrote:
> Agreed on all of the above, but if we don't need translation in
> the header line of \gdesc, gettext_noop for the strings is
> useless.

I have let that one alone, as all columns showing up in psql have the
same, consistent way of handling things.

> A period is missing in the comment for view_col_is_auto_updatable.

Fixed this one, and pushed. All things are back-patched where they
apply, except for the part of GetConfigOptionByNum getting only on HEAD
as it could be surprising after a minor upgrade as Tom has suggested.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-08-21 06:38:21 Re: Two proposed modifications to the PostgreSQL FDW
Previous Message David Rowley 2018-08-21 06:00:28 Re: ATTACH/DETACH PARTITION CONCURRENTLY