Re: ALTER TABLE on system catalogs

On 2018-08-20 11:37:49 +0900, Michael Paquier wrote:
> On Fri, Jul 13, 2018 at 11:05:10AM +0200, Peter Eisentraut wrote:
> > After reviewing that thread, I think my patch would still be relevant.
> > Because the pending proposal is to not add TOAST tables to some catalogs
> > such as pg_attribute, so my original use case of allowing ALTER TABLE /
> > SET on system catalogs would still be broken for those tables.
>
> Something has happened in this area in the shape of 96cdeae, and the
> following catalogs do not have toast tables: pg_class, pg_index,
> pg_attribute and pg_largeobject*. While 0001 proposed upthread is not
> really relevant anymore because there is already a test to list which
> catalogs do not have a toast table. For 0002, indeed the patch is still
> seems relevant. The comment block at the beginning of
> create_toast_table should be updated.

I still object to the approach in 0002.

Greetings,

Andres Freund