Re: remove ancient pre-dlopen dynloader code

On 2018-08-09 10:03:43 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2018-08-09 14:29:08 +0200, Peter Eisentraut wrote:
> >> The non-dlopen dynloader code for several operating systems is in some
> >> cases decades obsolete, and I have had some doubts that it would even
> >> compile anymore. Attached are patches for each operating system
> >> removing the obsolete code, with references to when it became obsolete.
>
> > Cool, I encountered those files a couple times when grepping for
> > things. +1 for the removal.
>
> LGTM, too.

This now generates a super nitpicky warning on at at least some linux +
clang configurations. I use -Weverything plus a lot of -Wno-*, and this
change added:

dynloader.c:7:4: warning: ISO C requires a translation unit to contain at least one declaration [-Wempty-translation-unit]
*/
^
1 warning generated.

I'll probably just neuter the warning, but I wanted to nevertheless
raise the "issue".

Greetings,

Andres Freund