Re: C99 compliance for src/port/snprintf.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: C99 compliance for src/port/snprintf.c
Date: 2018-08-15 16:11:00
Message-ID: 20180815161100.u2r2d4tjsfdmjs5b@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

Hi,

On 2018-08-15 12:01:28 -0400, Robert Haas wrote:
> On Wed, Aug 15, 2018 at 11:52 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > We could just mandate C99, more generally.
> >
> > /me goes and hides in a bush.
>
> It's hard to believe that would cost much.

Yea.

> Personally, I'd prefer to continue avoiding // comments and
> intermingled declarations of variables and code on grounds of style
> and readability.

I don't really care much about either. The calculus for intermingled
declarations would personally change the minute that we decided to allow
some C++ - allowing for scoped locks etc via RAII - but not earlier.

The thing I'd really want is designated initializers for structs. Makes
code for statically allocated structs *so* much more readable. And guess
who's working on code that adds statically allocated structs with lots
of members...

> BTW, I think a bush is probably not a nearly sufficient place to hide.
> The wrath of Tom will find you wherever you may go... :-)

That's why I keep moving. At 200 mph on a train :P. A continent away.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-15 16:17:18 Re: C99 compliance for src/port/snprintf.c
Previous Message Stephen Frost 2018-08-15 16:07:40 Re: C99 compliance for src/port/snprintf.c

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2018-08-15 16:17:18 Re: C99 compliance for src/port/snprintf.c
Previous Message Stephen Frost 2018-08-15 16:07:40 Re: C99 compliance for src/port/snprintf.c