Re: NLS handling fixes.

On Fri, Aug 10, 2018 at 03:21:31PM +0900, Kyotaro HORIGUCHI wrote:
> The cause is GetConfigOptionByNum is forgetting to retrieve
> translations for texts that have been marked with gettext_noop.
>
> Regarding GUCs, group names, short desc and long desc have
> translations so the attached first patch (fix_GUC_nls.patch) let
> the translations appear.
>
> Besides GUCs, I found another misuse of gettext_noop in
> pg_GSS_recvauth. (2nd fix_GSSerr_nls.patch)
>
> view_query_is_auto_updatable() and most of its caller are making
> the same mistake in a similar way. All caller sites require only
> translated message but bringing translated message around doesn't
> seem good so the attached third patch adds _() to all required
> places. (3rd fix_view_updt_nls.patch, 5th fix_vacuumdb_nls.patch)

I have been looking at all the things you are proposing here, and it
seems to me that you are right for these. I lack a bit of knowledge
about the translation of items, but can such things be back-patched?

> psql is making a bit different mistake. \gdesc seems intending
> the output columns names in NLS string but they actually
> aren't. DescribeQuery is using PrintQueryResults but it is
> intended to be used only for SendQuery. Replacing it with
> printQuery let \gdesc print NLS string but I'm not sure it is the
> right thing to fix this. (4th, fix psql_nls.patch)

This one I am not sure though...
--
Michael