Re: [PG_UPGRADE] 9.6 to 10.5

On Fri, Aug 10, 2018 at 06:42:40PM +0200, Michael Paquier wrote:
> On Fri, Aug 10, 2018 at 12:12:45PM -0400, Bruce Momjian wrote:
> > There is new code in PG 10.5 thta detects that the server is cleanly
> > shut down. You can no longer use '-m immediate' to shut down either
> > server, but 'smart' and 'fast' should be fine. Can you run
> > pg_controldata on each cluster before you run pg_upgrade to verify that
> > they say "Shutdown":
>
> You are talking about 244142d, right? I see this code bit:
> + if (strcmp(p, "shut down\n") != 0)
> + {
> + if (cluster == &old_cluster)
> + pg_fatal("The source cluster was not shut down cleanly.\n");
> + else
> + pg_fatal("The target cluster was not shut down cleanly.\n");
> + }
>
> This seems incorrect for me in the case of standbys, as pg_controldata
> reports in this case "shut down in recovery", and one can run pg_upgrade
> on a standby as well, no?

Oh, good point. I had not tested that. I can develop a patch to handle
this. Was that the case in this upgrade report?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +