| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical decoding / rewrite map vs. maxAllocatedDescs |
| Date: | 2018-08-09 17:58:46 |
| Message-ID: | 20180809175846.gyycn5rgbo7eksy5@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Aug-09, Tom Lane wrote:
> It sounds like whoever wrote that code was completely impervious to the
> API spec for AllocateFile():
>
> * Note that files that will be open for any significant length of time
> * should NOT be handled this way, since they cannot share kernel file
> * descriptors with other files; there is grave risk of running out of FDs
> * if anyone locks down too many FDs.
>
> Perhaps these files should be accessed through fd.c's VFD infrastructure
> rather than ignoring it. Reinventing it is especially not the way to go.
Ah, right. Maybe ReorderBufferRestoreChanges should use
PathNameOpenFile / FileRead ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-08-09 17:58:57 | Re: logical decoding / rewrite map vs. maxAllocatedDescs |
| Previous Message | hubert depesz lubaczewski | 2018-08-09 17:57:42 | xact_start meaning when dealing with procedures? |