From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jacob Champion <pchampion(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that |
Date: | 2018-08-07 18:54:19 |
Message-ID: | 20180807185418.GB27724@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Greetings,
* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Jacob Champion <pchampion(at)pivotal(dot)io> writes:
> > Thanks! We have made some progress towards a repro but we're having
> > problems putting it into the pg_dump suite.
>
> Yeah, I find the pg_dump test suite to be pretty much unreadable too.
> Don't worry about it --- I don't think we need to memorialize a test
> case for this.
This would be a similar case to the test:
COPY fk_reference_test_table second
and really wouldn't be very difficult to add, you just have to realize
that the regexp has be set up to match the output of pg_dump and that's
it's a multi-line one, as that test case is.
For my 2c, this seems like a pretty reasonable test to add and wouldn't
be very hard to do. If you'd like help, please reach out.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2018-08-07 19:34:49 | Re: Negotiating the SCRAM channel binding type |
Previous Message | Tom Lane | 2018-08-07 18:48:52 | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that |