Re: Documentaion fix.

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: michael(at)paquier(dot)xyz
Cc: alvherre(at)2ndquadrant(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Documentaion fix.
Date: 2018-08-03 07:23:13
Message-ID: 20180803.162313.235809608.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Fri, 3 Aug 2018 04:13:56 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20180802191356(dot)GB2247(at)paquier(dot)xyz>
> On Wed, Aug 01, 2018 at 01:04:37PM +0900, Kyotaro HORIGUCHI wrote:
> > The query and the result with four columns fit the current width.
>
> Just wondering, what is your reason behind the addition of restart_lsn?
> This part of the documentation focuses on slot creation, so slot_name,
> slot_type and active would be representative enough, no?

The first reason was the example looks having a bit too many
space around only with three other columns.

A more serious reason is that I wanted to show a slot with what
properties is created in the example and I thought that
restart_lsn and temporary are significant. Howerver restart_lsn
is always a part of the pg_replication_slots, we don't have
"temprary" before 10. Addition to that, adding it makes the
SELECT line stick out of the width.

That said, I don't object to reduce the columns. Please find the
attached.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v3-0001-Documentation-fix-of-Log-Shipping_mst-96.patch text/x-patch 1.5 KB
v3-0001-Documentation-fix-of-Log-Shipping_95-94.patch text/x-patch 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-08-03 07:34:43 Re: Ideas for a relcache test mode about missing invalidations
Previous Message Ashutosh Bapat 2018-08-03 06:18:38 Re: Problem while updating a foreign table pointing to a partitioned table on foreign server