| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [report] memory leaks in COPY FROM on partitioned table |
| Date: | 2018-08-01 21:03:11 |
| Message-ID: | 20180801210311.amousjht4pchceac@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Aug-01, Andres Freund wrote:
> On 2018-08-01 16:38:11 -0400, Alvaro Herrera wrote:
> > On 2018-Jul-24, Amit Langote wrote:
> >
> > > Your patch takes care of allocation happening inside
> > > get_partition_for_tuple, but as you mention there might be others in its
> > > caller ExecFindPartition. So, I think we should switch to the per-tuple
> > > context in ExecFindPartition.
> >
> > Right, makes sense. Pushed that way.
>
> The buildfarm does not like this one:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=desmoxytes&dt=2018-08-01%2020%3A40%3A02
> (and a lot of other reports from my animals)
Hmm, variable shadowing ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2018-08-01 21:08:57 | Re: make installcheck-world in a clean environment |
| Previous Message | Andres Freund | 2018-08-01 20:44:11 | Re: [report] memory leaks in COPY FROM on partitioned table |