| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Schneider, Jeremy" <schnjere(at)amazon(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Albin, Lloyd P" <lalbin(at)scharp(dot)org> |
| Subject: | Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack |
| Date: | 2018-07-26 20:41:27 |
| Message-ID: | 20180726204127.GA1754@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Jul 26, 2018 at 03:06:59PM +0000, Bossart, Nathan wrote:
> I took a look at 0001.
Thanks for the lookup. 0003 is the most simple in the set by the way.
> On 7/26/18, 12:24 AM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> - myrelid = RelationGetRelid(rel);
> + myrelid = RangeVarGetRelidExtended(rv, AccessExclusiveLock,
> + false, RangeVarCallbackForTruncate, NULL);
>
> Should the flags argument be 0 instead of false?
Yes, those should be 0. All patches are missing that. It does not have
a bad consequence on the patch, still that's incorrect.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2018-07-26 20:42:35 | BUG #15301: Scanning all partition when more than 100 items in "where id in ()" clause |
| Previous Message | Andres Freund | 2018-07-26 20:23:23 | Re: BUG #15299: relation does not exist errors |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-07-26 20:42:24 | Re: How can we submit code patches that implement our (pending) patents? |
| Previous Message | Dave Cramer | 2018-07-26 20:40:18 | why doesn't pg_create_logical_replication_slot throw an error if the encoder doesn't exist |