Re: pgsql: Deduplicate "invalid input syntax" messages for various types.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Deduplicate "invalid input syntax" messages for various types.
Date: 2018-07-23 00:49:58
Message-ID: 20180723004958.GB2854@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Jul 22, 2018 at 10:30:20PM +0000, Andres Freund wrote:
> Deduplicate "invalid input syntax" messages for various types.
>
> Previously a lot of the error messages referenced the type in the
> error message itself. That requires that the message is translated
> separately for each type.
>
> Note that currently a few smallint cases continue to reference the
> integer, rather than smallint, type. A later patch will create a
> separate routine for 16bit input.

A couple of alternate outputs have been forgotten here (int8 has some
extra ones), causing make check to turn red on Windows, and plcheck to
turn red on macos.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-07-23 00:53:36 Re: pgsql: Deduplicate "invalid input syntax" messages for various types.
Previous Message Andres Freund 2018-07-23 00:49:03 pgsql: Mop-up for 3522d0eaba5, which missed some alternative output fil