From: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Non-portable shell code in pg_upgrade tap tests |
Date: | 2018-07-20 14:55:08 |
Message-ID: | 20180720175508.07776219@fafnir.local.vm |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 20 Jul 2018 10:25:47 -0400
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> writes:
> > I've discovered that in the branch REL_11_STABLE there is shell
> > script src/bin/pg_upgrade/test.sh which doesn't work under Solaris
> > 10. (it uses $(command) syntax with is not compatible with original
> > Solaris /bin/sh)
>
> Please send a patch. Most of us do not have access to old shells
Here it goes. Previous letter was written before fixed tests were
completed, because this old machine is slow.
> we could test this on. (The oldest machine I have, and it's old
> enough to vote, does run that script ... I doubt very many other
> developers have anything older.)
>
> regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
original_systemV_sh_compatibility.patch | text/x-patch | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2018-07-20 14:57:16 | Re: Making "COPY partitioned_table FROM" faster |
Previous Message | Tom Lane | 2018-07-20 14:48:15 | Re: Fw: Windows 10 got stuck with PostgreSQL at starting up. Adding delay lets it avoid. |