[pgagent] Instatallation destination?

From: Christoph Berg <myon(at)debian(dot)org>
To: pgAdmin support <pgadmin-support(at)postgresql(dot)org>
Subject: [pgagent] Instatallation destination?
Date: 2018-07-20 09:00:16
Message-ID: 20180720090016.GD15185@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Hi,

in the Debian package I notice that CMakeLists.txt installs README and
LICENSE to /usr (no subdirectory!), and pgagent.sql to /usr/share.
The first is clearly wrong, and the second somewhat debatable. As
pgagent.sql is not really required (extension support), I added this
patch:

Don't install README and LICENSE which would otherwise end up in /usr,
and don't install pgagent.sql to /usr/share.

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -144,11 +144,11 @@ IF (WIN32)
INSTALL(FILES ${pgagent_SOURCE_DIR}/sql/pgagent.sql DESTINATION .)
ELSE(WIN32)
INSTALL(TARGETS pgagent DESTINATION bin)
- INSTALL(FILES ${pgagent_SOURCE_DIR}/sql/pgagent.sql DESTINATION share)
+ #INSTALL(FILES ${pgagent_SOURCE_DIR}/sql/pgagent.sql DESTINATION share)
ENDIF(WIN32)

-INSTALL(FILES ${pgagent_SOURCE_DIR}/README DESTINATION .)
-INSTALL(FILES ${pgagent_SOURCE_DIR}/LICENSE DESTINATION .)
+#INSTALL(FILES ${pgagent_SOURCE_DIR}/README DESTINATION .)
+#INSTALL(FILES ${pgagent_SOURCE_DIR}/LICENSE DESTINATION .)

# Extension
IF(PG_EXTENSION)

What would be the proper fix?

Christoph

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2018-07-20 09:06:45 Re: [pgagent] patch: link with -pthread
Previous Message Dave Page 2018-07-20 08:59:35 Re: [pgagent] patch: supported cmake version