Re: pgsql: Rework error messages around file handling

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Rework error messages around file handling
Date: 2018-07-17 23:53:19
Message-ID: 20180717235319.GB2998@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jul 17, 2018 at 07:23:04PM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > Rework error messages around file handling
>
> longfin thinks you missed at least one cast ...

Hm, I checked that. Just casting to (Size) should do it. I cannot get
a warning with neither clang nor gcc on Debian SID even with -Wformat,
and no OSX at hand.

So the attached would fix the problem?
--
Michael

Attachment Content-Type Size
printf-zu-osx.patch text/x-diff 498 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-07-18 00:02:43 Re: pgsql: Rework error messages around file handling
Previous Message Tom Lane 2018-07-17 23:23:04 Re: pgsql: Rework error messages around file handling