| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, petr(at)2ndquadrant(dot)com, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Non-reserved replication slots and slot advancing |
| Date: | 2018-07-10 08:29:32 |
| Message-ID: | 20180710082932.GM1661@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 10, 2018 at 01:16:30AM -0700, Andres Freund wrote:
> On 2018-07-10 16:59:07 +0900, Michael Paquier wrote:
> > if (moveto < minlsn)
> > - {
> > - ReplicationSlotRelease();
> > ereport(ERROR,
> > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> > - errmsg("cannot move slot to %X/%X, minimum is %X/%X",
> > + errmsg("cannot advance replication slot to %X/%X, minimum is %X/%X",
> > (uint32) (moveto >> 32), (uint32) moveto,
> > (uint32) (minlsn >> 32), (uint32) minlsn)));
> > - }
>
> If you're touching this, I'd also change the errcode here.
Yep, let's change that as well. If you want to look at that stuff more
deeply, please feel free. Otherwise I could always push what I have
now.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2018-07-10 08:29:57 | RE: How can we submit code patches that implement our (pending) patents? |
| Previous Message | Julien Rouhaud | 2018-07-10 08:28:09 | Re: [Tiny Debug Issue] Undefined Reference problem encountered during compile |