Re: pgsql: Use access() to check file existence in GetNewRelFileNode()

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use access() to check file existence in GetNewRelFileNode()
Date: 2018-07-08 17:27:33
Message-ID: 20180708172733.pwomywupfcwiylby@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2018-07-08 10:05:53 -0400, Andrew Dunstan wrote:
> On 07/08/2018 06:00 AM, Michael Paquier wrote:
> > Reviewed-by: Peter Eisentraut, Michael Paquier
> >
>
> I think if you're the committer you're assumed to have reviewed the patch
> :-)

I personally think it makes sense to put oneself there. At least I order
the Reviewed-By etc lists roughly by the amount of work done. Sometimes
you come across a patch where others have done most of the review work,
so it's sensible to put yourself last. In other cases you might have
spent months of effort - so first.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2018-07-08 17:51:35 pgsql: Correct obsolete unique index insertion comment.
Previous Message Andrew Dunstan 2018-07-08 14:05:53 Re: pgsql: Use access() to check file existence in GetNewRelFileNode()