| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Speedup of relation deletes during recovery |
| Date: | 2018-07-03 02:28:17 |
| Message-ID: | 20180703022817.GH2159@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 03, 2018 at 04:13:15AM +0900, Fujii Masao wrote:
> OK, so what about the attached patch?
I have been looking at this patch, and this looks in good shape to me
(please indent!).
+ * Call smgrclose() in reverse order as when smgropen() is called.
+ * This trick enables remove_from_unowned_list() in smgrclose()
+ * to search the SMgrRelation from the unowned list,
+ * in O(1) performance.
A nit here: with O(1) performance.
Could it be possible to add an assertion so as isRedo is never enabled
out of recovery?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-07-03 02:33:01 | Re: Unexpected behavior of DROP VIEW/TABLE IF EXISTS |
| Previous Message | Jaime Casanova | 2018-07-03 02:05:57 | Re: automatic restore point |