| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Pg Committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: Tips on committing |
| Date: | 2018-07-02 09:24:08 |
| Message-ID: | 20180702092408.GE4841@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jun 29, 2018 at 06:02:07PM -0400, Bruce Momjian wrote:
> On Thu, Jun 28, 2018 at 09:46:17AM -0700, Peter Geoghegan wrote:
>> * Don't assume that you haven't broken the doc build if you make even
>> a trivial doc change. Removing a GUC can break instances in the
>> release notes where they're referenced. Even grep can miss this, since
>> references to the GUC will have dashes rather than underscores, plus
>> possibly other variations.
>
> Yes, I even check the docs after whitespace changes.
Could it be possible to mention as well to run pgindent before a commit?
After the indent run done for 11 beta 1, and it was just a matter of
days before some garbage diffs have accumulated in the C code, which
makes local runs more annoying when the same files are touched.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-02 13:23:52 | pgsql: Add wait event for fsync of WAL segments |
| Previous Message | Michael Paquier | 2018-07-02 04:32:32 | pgsql: Correct function name in comment of logical decoding code |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-07-02 09:25:00 | Re: Large Commitfest items |
| Previous Message | Masahiko Sawada | 2018-07-02 09:22:46 | Re: Threat models for DB cryptography (Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key) Management Service (KMS) |