From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Typo in llvm_function_reference |
Date: | 2018-06-27 06:20:25 |
Message-ID: | 20180627062025.ppg64cv44dvsgftt@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2018-06-27 10:46:35 +0530, Rushabh Lathia wrote:
> There is multiple return statement in llvm_function_reference
> and that's definitely looks typo. Here is the patch to fix the
> same.
> diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
> index daae964..5d0cdab 100644
> --- a/src/backend/jit/llvm/llvmjit.c
> +++ b/src/backend/jit/llvm/llvmjit.c
> @@ -394,7 +394,6 @@ llvm_function_reference(LLVMJitContext *context,
> LLVMSetGlobalConstant(v_fn, true);
>
> return LLVMBuildLoad(builder, v_fn, "");
> - return v_fn;
> }
>
> /* check if function already has been added */
Thanks! Pushed.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2018-06-27 06:28:47 | Re: postgresql_fdw doesn't handle defaults correctly |
Previous Message | Peter Eisentraut | 2018-06-27 06:20:21 | commitfest app moving patch error |