| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Thomas Reiss <thomas(dot)reiss(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Performance regression with PostgreSQL 11 and partitioning |
| Date: | 2018-06-26 14:43:34 |
| Message-ID: | 20180626144334.vuim65zawuook37b@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Jun-25, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > On 2018-Jun-18, David Rowley wrote:
> >> I've attached a patch which cleans up my earlier version and moves the
> >> setup of the append_rel_array into its own function instead of
> >> sneaking code into setup_simple_rel_arrays(). I've also now updated
> >> the comment above find_childrel_appendrelinfo(), which is now an
> >> unused function.
>
> > I checked that this patch fixes the originally reported performance
> > regression.
> > Unless there are objections, I intend to push this patch tomorrow.
>
> If find_childrel_appendrelinfo is now unused, we should remove it.
Agreed -- thanks for following up. Pushed that way.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseeev | 2018-06-26 14:44:03 | Re: [GSoC] working status |
| Previous Message | Arseny Sher | 2018-06-26 14:04:22 | Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding. |