| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | "lizenko79(at)gmail(dot)com" <lizenko79(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15252: "do not dump comments" in pg_restore help |
| Date: | 2018-06-26 06:02:04 |
| Message-ID: | 20180626060204.GE31353@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Jun 25, 2018 at 01:26:38PM +0300, Sergei Kornilov wrote:
> Thank you! I recheck behavior too, option works correct and has only
> wrong description. Simple patch attached.
This is clearly a copy-pasto from recent commit 1368e92, nice catch.
> <listitem>
> <para>
> - Do not dump comments.
> + Do not restore comments.
> </para>
> </listitem>
> </varlistentry>
This is not consistent with the other --no-XXX switches, so I have
reworded the documentation fix to be more consistent with the rest and
pushed the patch. I can confirm as well after some manual testing that
the feature behaves as documented.
Thanks for the report and the patch!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pash Ebash | 2018-06-26 11:07:42 | Found incorrect output in pg_lsclusters |
| Previous Message | David G. Johnston | 2018-06-26 01:03:22 | Re: Converting to UTC multiple times converts back to local time zone |