| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incorrect errno used with %m for backend code |
| Date: | 2018-06-25 02:26:14 |
| Message-ID: | 20180625022614.GB1146@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jun 24, 2018 at 09:23:50PM +0900, Michael Paquier wrote:
> On Sun, Jun 24, 2018 at 09:22:01AM +0530, Ashutosh Sharma wrote:
>> Okay, I too had a quick look into the source code to see if there are
>> still some places where we could have missed to set an errno to ENOSPC
>> in case of write system call failure but, couldn't find any such place
>> in the code. The v2 version of patch looks good to me.
>
> Thanks for the review. I'll try to wrap that tomorrow with proper
> patches for back-branches as things diverge a bit here and there.
Pushed down to 9.3. All branches conflicted, and particularly in
pg_basebackup some write() calls have been moved around.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-06-25 02:30:43 | Re: postgresql_fdw doesn't handle defaults correctly |
| Previous Message | Craig Ringer | 2018-06-25 01:32:36 | Re: PATCH: backtraces for error messages |