Re: using pg_basebackup for point in time recovery

On Thu, Jun 21, 2018 at 04:50:38PM -0700, David G. Johnston wrote:
> Generally only actual bug fixes get back-patched; but I'd have to say
> this looks like it could easily be classified as one.

Everybody is against me here ;)

> Some comments on the patch itself:
>
> "recover up to the wanted recovery point." - "desired recovery point" reads
> better to me
>
> ====
> "These backups are typically much faster to backup and restore" - "These
> backups are typically much faster to create and restore"; avoid repeated
> use of the word backup

Okay.

> "but can result as well in larger backup sizes" - "but can result in larger
> backup sizes", drop the unnecessary 'as well'

Okay.

> I like adding "cold backup" here to help contrast and explain why a base
> backup is considered a "hot backup". The rest is style to make that flow
> better.

Indeed. The section uses hot backups a lot.

What do all folks here think about the updated attached?
--
Michael