Re: Speedup of relation deletes during recovery

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Speedup of relation deletes during recovery
Date: 2018-06-21 05:40:58
Message-ID: 20180621054058.GF1679@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 20, 2018 at 08:43:11PM -0700, Andres Freund wrote:
> On 2018-06-18 11:13:47 -0700, Andres Freund wrote:
>> We could do that - but add_to_unowned_list() is actually a bottleneck in
>> other places during recovery too. We pretty much never (outside of
>> dropping relations / databases) close opened relations during recovery -
>> which is obviously problematic since nearly all of the entries are
>> unowned. I've come to the conclusion that we should have a global
>> variable that just disables adding anything to the global lists.
>
> On second thought: I think we should your approach in the back branches,
> and something like I'm suggesting in master once open.

+1. Let's also make sure that the removal of smgrdounlink and
smgrdounlinkfork happens only on master.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nico Williams 2018-06-21 05:53:48 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)
Previous Message Michael Paquier 2018-06-21 05:37:46 Re: Adding tests for inheritance trees with temporary tables