From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Adding tests for inheritance trees with temporary tables |
Date: | 2018-06-20 06:09:55 |
Message-ID: | 20180620060955.GF19346@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 19, 2018 at 01:04:43PM +0530, Ashutosh Bapat wrote:
> Thanks. Some review comments here.
Thanks for the review!
> +create table inh_perm_parent (a1 int);
> +create temp table inh_temp_parent (a1 int);
> +create temp table inh_temp_child (a1 int) inherits (inh_perm_parent); -- ok
> +NOTICE: merging column "a1" with inherited definition
>
> You could actually avoid this notice by changing create table statement like
> create temp table inh_temp_child () inherits (inh_perm_parent);
Okay, fixed.
> select tabloid::regclass will also print the name of the table where
> the row resides. That will be useful to check where the rows come from
> and also to test the inheritance children.
Good point, I have added those. Except that you meant
tableoid::regclass.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
inherit-temp-tests-v2.patch | text/x-diff | 2.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-06-20 06:21:42 | Re: PANIC during crash recovery of a recently promoted standby |
Previous Message | Amit Langote | 2018-06-20 05:44:18 | Re: ToDo: show size of partitioned table |