Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()
Date: 2018-06-17 10:18:06
Message-ID: 20180617101806.GC1411@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jun 15, 2018 at 11:01:26AM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
>> Perhaps we could acquire the short.pg domain and run it off that.
>
> We're already using postgr.es, so it's not going to get much shorter
> just from mucking with the domain part. We'd need to set up some
> abbreviation for the message-ID part, which I'm not for. It would
> add more overhead to writing commit log entries (to create or find
> out the right abbreviation), and it would make it harder to go back
> and forth between the commit log and local mail archives, and it'd
> be yet another Thing We Have To Keep Running Forever.

I am also -1 for any kind of message-id shorteners in the commit
messages. I cannot say for others, but sometimes I work offline with
only the git history and a cold copy of Postgres archives, meaning that
depending on an external source to get the raw message IDs would break
that.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-06-17 20:15:27 pgsql: Suppress -Wshift-negative-value warnings.
Previous Message Michael Paquier 2018-06-17 09:02:04 Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()