| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Christian Ullrich <chris(at)chrullrich(dot)net>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, buildfarm(at)sraoss(dot)co(dot)jp, dpage(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: pg_config.h.win32 missing a set of flags from pg_config.h.in added in v11 development |
| Date: | 2018-06-13 02:06:32 |
| Message-ID: | 20180613020632.GD3138@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 13, 2018 at 09:07:20AM +0900, Michael Paquier wrote:
> What kind of failures are you seeing? I just compiled Postgres two days
> ago with MSVC and OpenSSL 1.0.2o (oldest version with a Windows
> installer I could find), and that was able to compile. On HEAD, OpenSSL
> should be supported down to 0.9.8. This thread discusses about whether
> we want to enforce HAVE_X509_GET_SIGNATURE_NID unconditionally or not,
> as it is disabled now. Even if the code is linked to 1.0.2 and the flag
> is not set, then the code should be able to compile.
So, I was looking at this part this morning, and I would suggest the
attached, which enables HAVE_X509_GET_SIGNATURE_NID and
HAVE_SSL_CLEAR_OPTIONS, raising the bar to have at least OpenSSL 1.0.2
on Windows (that's the minimum version easily findable when it comes to
MSI installers anyway these days). I have checked that the code is able
to compile correctly as well.
HAVE_LDAP_INITIALIZE is added in the list, but this is disabled as I
could not test it. It could always be possible to revisit that later.
Thomas, what do you think?
Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Track-new-configure-flags-introduced-for-11-in-pg_co.patch | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-06-13 02:22:40 | Re: Needless additional partition check in INSERT? |
| Previous Message | Haribabu Kommi | 2018-06-13 01:42:14 | Re: Does logical replication supports cross platform servers? |