| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info? |
| Date: | 2018-06-06 23:11:00 |
| Message-ID: | 20180606231100.ypy7r3mazlyjqzd4@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-06-06 21:25:14 +0100, Andrew Gierth wrote:
> >>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:
>
> Andres> I think it's not unreasonable to think of it that way, but it's
> Andres> really not how it is used today. In pretty much all cases the
> Andres> collation is known and determined at the time fmgr_info() is
> Andres> called (we also commonly reuse FunctionCallInfoData structs).
>
> The obvious case which is not one of those "pretty much all cases" is
> where DirectFunctionCallN[Coll] is used - which turns out to be not all
> that unusual.
There the callsite just lives for just one call, I don't really see that
being an exception?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-06-06 23:16:52 | Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info? |
| Previous Message | Tomas Vondra | 2018-06-06 23:06:19 | Re: POC: GROUP BY optimization |