From: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: adding tab completions |
Date: | 2018-05-29 09:27:27 |
Message-ID: | 20180529092726.GA6535@zakirov.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
On Mon, May 28, 2018 at 07:06:23PM -0500, Justin Pryzby wrote:
> Find attached tab completion for the following:
The patch works well. I have a couple notes.
The patch replaces the variable Query_for_list_of_tmf by
Query_for_list_of_tpmf. So I think Query_for_list_of_tmf isn't needed
anymore and can be removed.
I created partitioned table "measurement" and tried tab completion.
VACUUM (ANALYZE) measurement (<tab>
gives me only a comma. If I try to input table column:
VACUUM (ANALYZE) measurement (city_id<tab>
replaces "city_id" column by a comma: "VACUUM (ANALYZE) measurement (,".
The following with whitespace after column works well:
VACUUM (ANALYZE) measurement (city_id <tab>
and gives: "VACUUM (ANALYZE) measurement (city_id ,".
Also I think it could be good to list column names after parentheses,
but I'm not sure if it easy to implement.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Geoff Winkless | 2018-05-29 10:11:09 | Re: Is a modern build system acceptable for older platforms |
Previous Message | Craig Ringer | 2018-05-29 08:53:36 | Re: Postgres, fsync, and OSs (specifically linux) |