| From: | Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru> |
|---|---|
| To: | Charles Cui <charles(dot)cui1984(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: [GSoC] github repo and initial work |
| Date: | 2018-05-25 06:23:15 |
| Message-ID: | 20180525092315.758b9aac@asp437-24-g082ur |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 24 May 2018 18:25:28 -0700
Charles Cui <charles(dot)cui1984(at)gmail(dot)com> wrote:
> The second is to provide thrift type just like json or jsonb. When you
> create a table, postgres knows ::thrift keywords.
> I think method one should be easier to implement because it only
> limits to this plugin. Method two needs modify postgres kernel to
> register a new type, which may time consuming,
> but more natural. Any ideas on this?
>
> Thanks, Charles
Hi Charles,
I prefer the second way with separate type. But I think it is good idea
to wait for an answer from your project mentor or someone other.
I'm not an expert in PostgreSQL user-defined types, but AFAIK, it
doesn't require changes in PostgreSQL core, since types can be created
in extensions. It doesn't require changes to grammar or something.
You can look at citext contrib as an example.
--
Aleksandr Parfenov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-05-25 06:23:44 | Re: Possible bug in logical replication. |
| Previous Message | Heikki Linnakangas | 2018-05-25 06:05:21 | Re: XLogWrite uses palloc within a critical section |