From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: A Japanese-unfriendy error message contruction |
Date: | 2018-05-25 01:05:14 |
Message-ID: | 20180525.100514.183683663.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Thu, 24 May 2018 14:20:21 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in <24988(dot)1527186021(at)sss(dot)pgh(dot)pa(dot)us>
> Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> > Hello. Here is the patch set.
>
> Thanks! I pushed all this plus fixes for the OCLASS_PUBLICATION_REL
> code.
Thanks.
> The only non-cosmetic change I made was that I didn't much like what
> you'd done with the OCLASS_DEFACL code: it seemed quite confusing to
> be renaming buffers like that, plus it was still assuming more than
> I thought it should about how the message would go together in the end.
> I took the advice of the manual instead, and just made pairs of
> near-duplicate messages to be translated separately.
I wasn't sure that which way is better. This doubles the
msgids. But I can live with it since it would be scaecely
changed.
> I'm still not sure whether the OCLASS_DEFAULT case is satisfactorily
> translatable. It would not take a lot more code to expand its message to
> "default value for column %s of %s", where the second %s is the result of
> getRelationDescription. However, I have no idea whether there are any
> translations where that would really work noticeably better.
True. I think we don't have difficulties as for Japanese
translation.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Charles Cui | 2018-05-25 01:25:28 | Re: [GSoC] github repo and initial work |
Previous Message | Asim Praveen | 2018-05-25 01:03:17 | Keeping temporary tables in shared buffers |