| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | andrew(dot)dunstan(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Time to put context diffs in the grave |
| Date: | 2018-05-23 00:17:18 |
| Message-ID: | 20180523001718.GC3461@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 22, 2018 at 06:59:56PM +0900, Kyotaro HORIGUCHI wrote:
> filterdiff has a bug that we can lose a part of hunks with it,
> and I actually have stepped on it. I saw Álvaro made a complaint
> about the bug but it doesn't seem to have been fixed. It is the
> most major reason I'm posting patches in unified format
> hesitently (really I am!). The second reason is git format-patch
> doesn't give me diffs in context format.
Yeah, I have been bitten by that one too, as well as others:
https://www.postgresql.org/message-id/CAJghg4J6Anwob_c-g8B6CX6bzh81L9qNnB0f44r-x59fhMugEg@mail.gmail.com
https://www.postgresql.org/message-id/20170913.174239.25978735.horiguchi.kyotaro@lab.ntt.co.jp
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2018-05-23 00:19:34 | Re: SCRAM with channel binding downgrade attack |
| Previous Message | Michael Paquier | 2018-05-23 00:13:32 | Re: PostgreSQL “tuple already updated by self” |