Re: [BUG] Re-entering malloc problem when use --enable-nls buildpostgresql

From: Andres Freund <andres(at)anarazel(dot)de>
To: 158306855 <anderson2013(at)qq(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: [BUG] Re-entering malloc problem when use --enable-nls buildpostgresql
Date: 2018-05-22 21:11:45
Message-ID: 20180522211145.mpmbs2365neosqiv@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2018-05-21 10:49:53 +0800, 158306855 wrote:
> > It'd be fairly unproblematic to write an untranslated message out. There
> > we can make sure to either only use plain syscalls or use memory from
> > the preallocated context. I think it'd be ok to not to translate in
> > that situation.
>
>
> I wrote a patch to improve this problem.
>
> +extern int errmsg_no_translateit(const char *fmt,...) pg_attribute_printf(1, 2);
> +extern int errdetail_no_translateit(const char *fmt,...) pg_attribute_printf(1, 2);
> +extern int errhint_no_translateit(const char *fmt,...) pg_attribute_printf(1, 2);
> +
> /*
> * errcontext() is typically called in error context callback functions, not
> * within an ereport() invocation. The callback function can be in a different

Can't we just reuse errmsg_internal etc?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-05-23 03:01:31 Re: postgres_fdw misbehaviour using "DELETE ... RETURNING *"
Previous Message Euler Taveira 2018-05-22 03:49:10 Re: crash while decoding INSERT ON CONFLICT