From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | robertmhaas(at)gmail(dot)com |
Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: log_min_messages shows debug instead of debug2 |
Date: | 2018-05-17 08:58:18 |
Message-ID: | 20180517.175818.184554580.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Wed, 16 May 2018 12:37:48 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in <CA+TgmobTWhCE_k8mKW+S3P4Rizz-4AZcax_9XjDjf0G0fn24Ng(at)mail(dot)gmail(dot)com>
> On Wed, May 16, 2018 at 11:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >> On Tue, May 15, 2018 at 4:46 AM, Ideriha, Takeshi
> >> <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> wrote:
> >>> I noticed that if log_min_messages is set to ‘debug2’, it shows ‘debug’
> >>> instead of debug2.
> >
> >> Seems worth changing to me. Anyone else think differently?
> >
> > I think the current behavior was intentional at some point, probably
> > with the idea that if you put in "debug" it should come out as "debug".
>
> Hmm, that's an angle I hadn't considered.
>
> > This patch just moves the discrepancy. Still, it's more precise to
> > print debug2, so I'm okay with changing.
>
> OK. Let's see if anyone else has an opinion.
It's not about me, but without knowing the history, "debug" can
look as if it is less chatty than "debug2" or even "debug1". All
log level of "debugN" are seen as DEBUG in log lines. Thus
showing "debug2" as just "debug" may obfuscate the cause of
having so many log lines.
From another view point, it can be thought as not-good that print
a value with a hidden word.
In short, I submit +1 for this.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-05-17 09:09:50 | Re: [PATCH] Use access() to check file existence in GetNewRelFileNode(). |
Previous Message | Thomas Munro | 2018-05-17 08:39:50 | Re: inconsistency and inefficiency in setup_conversion() |